search

SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
267 stars 127 forks source link

Dayjs Datetime Adapter is not able to apply to specific date picker #12251

Closed I523138 closed 2 months ago

I523138 commented 2 months ago

Is this a bug, enhancement, or feature request?

enhancement

Describe your proposal.

Dayjs Datetime Adapter should be able to apply to specific date picker

In our app, we have a new feature request to apply custom date format to specific date picker, but we find that currently the Dayjs Datetime Adapter is only able to apply to all date picker on the page

we are seeking for solutions to apply DayjsDatetimeAdapter formats to single objects.

Can you handle that on the application side

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

angular/core": "15.2.10", fundamental-ngx/core": "0.43.39", fundamental-ngx/datetime-adapter": "0.43.39",

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Did you check the documentation and the API?

yes https://fundamental-ngx.netlify.app/#/core/dayjs-datetime-adapter

Did you search for similar issues?

Is there anything else we should know?

IMPORTANT: Please refrain from providing links or screenshots of SAP's internal information, as this project is open-source, and its contents are accessible to anyone.

shawchandankumar commented 2 months ago

@droshev Do we have to implement the solution for just the DayjsDateTime or for the FdDateTime as well?

droshev commented 2 months ago

@droshev Do we have to implement the solution for just the DayjsDateTime or for the FdDateTime as well?

Can you precise what you mean with the solution?

shawchandankumar commented 2 months ago

@droshev Do we have to implement the solution for just the DayjsDateTime or for the FdDateTime as well?

Can you precise what you mean with the solution?

I mean to say for this requirement what the implementation would look like? Currently the date-picker component is using the date format for either the DayjsDateTime or the fdDateTime so we can introduce a new Input decorator which could be passed as a new format of the date to the dateTimeAdapter.

I523138 commented 2 months ago

Hi，Team
Thanks to your effort and help, I see the change is merged, and when will it be actually deployed to new version?

droshev commented 2 months ago

@I523138 it will be as part of version v0.51.3 and we plan releasing it in the next few days.

noooraG commented 2 months ago

Hi team, I tried to upgrade to v0.51.3 but had conflict dependency error. We are using @angular/animations with version 15.2.10, can we have this new function for angular 15?

peer @angular/animations@"^18.0.0" from @fundamental-ngx/cdk@0.51.3

droshev commented 2 months ago

@noooraG Angular 15 is not supported officially(here). The version that gets new development is Angular 18.