search

SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
265 stars 126 forks source link

Busy Indicator in Component dialog not closing after value change #12471

Open Ashah2013 opened 5 days ago

Ashah2013 commented 5 days ago

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

In component based dialog, any data change after initial load is not reflected until a click event or button press event is triggered.

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

Angular version - 18.0.3 Fundamental NGX version - 0.52.0

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Open a component based dialog. Change any value of a variable or set busyindicator to false after sometime or after completion of any API call. The changes are not reflected until you click or press any button.

Please provide relevant source code if applicable.

https://stackblitz.com/edit/angular-mylhjb-xdxs7j?file=src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fdialog-example.component.ts

Did you check the documentation and the API?

Yes

Did you search for similar issues?

Yes, https://github.com/SAP/fundamental-ngx/issues/9682

IMPORTANT: Please refrain from providing links or screenshots of SAP's internal information, as this project is open-source, and its contents are accessible to anyone.

droshev commented 5 days ago

@khotcholava Can you check this ticket quickly? Thanks.

khotcholava commented 4 days ago

@Ashah2013 Can you please check this stackblitz link? Here is the solution for you.

Ashah2013 commented 4 days ago

Do we need to use changeDetectorRef.detectChanges() all the time?? This issue happened in all dialogs only after the fundamental ngx upgrade. We have many dialogs and every dialog has some API calls.. if we follow this approach, we would need to do detectChanges at many places. Has something changed recently in dialog component which caused this?

khotcholava commented 4 days ago

@Ashah2013 This is a temporary solution if you need it. Of course I need to dig deeper to find the actual solution.

droshev commented 1 day ago

@khotcholava do you think you can find the root cause why the dialog changed?