SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
269 stars 129 forks source link

fix(platform): Update info bar table to reflect selected filters #12634

Closed khotcholava closed 2 weeks ago

khotcholava commented 1 month ago

fix(platform): table showing info bar with selected filters

closes #11783

khotcholava commented 1 month ago

NOTE:

!!! Not yet ready for review !!!

netlify[bot] commented 1 month ago

Deploy Preview for fundamental-ngx ready!

Name Link
Latest commit e736a333db0df7ec90977eee21e3b11ef6f5d1e6
Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/67176b6b0dca670008e1b8da
Deploy Preview https://deploy-preview-12634--fundamental-ngx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for fundamental-ngx ready!

Name Link
Latest commit b38503252a308f46579a6a3db6644e4994705646
Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6720d1a52f6771000862e8d3
Deploy Preview https://deploy-preview-12634--fundamental-ngx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit b385032):

https://fundamental-ngx-gh--pr12634-11783-infobar-showin-44silskm.web.app

(expires Fri, 01 Nov 2024 12:18:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

InnaAtanasova commented 4 weeks ago

Still shows [object Object] Screenshot 2024-10-28 at 9 45 38 AM

do-oel commented 2 weeks ago

Thanks for this fix! Highly appreciated.

Two smaller things for improvement:

  1. The filter info bar shows an index number in front of the filter term. This should be hidden (e.g, Filtered by: StatusColor (0: positive)
  2. The category name is using no spaces, this seems a bit weird (e.g, StatusColor instead of Status Color)
image
khotcholava commented 1 week ago

@do-oel Can you please create stackblitz example for reproducing this issue?

do-oel commented 1 week ago

Hi @khotcholava, you can experience the issue in the documentation example: https://sap.github.io/fundamental-ngx/#/platform/table/settings-dialog-table#filterable