SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
269 stars 129 forks source link

fix(core): Checkbox link in label is not clickable #12636

Closed khotcholava closed 4 days ago

khotcholava commented 1 month ago

fix(core): Checkbox link in label is not clickable

closes #12577

Description

Updated the checkbox component to ensure that links within custom labels are clickable and function as intended. This resolves the issue observed in the documentation example.

Before

Screencast from 2024-10-23 16-34-31.webm

After

new.webm

netlify[bot] commented 1 month ago

Deploy Preview for fundamental-ngx ready!

Name Link
Latest commit e3073f40e1afdf187711939bb0654ff084e1551b
Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6740cee081c6bf0008910f75
Deploy Preview https://deploy-preview-12636--fundamental-ngx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit e3073f4):

https://fundamental-ngx-gh--pr12636-12577-core-fix-check-7x957j9l.web.app

(expires Mon, 25 Nov 2024 18:39:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

droshev commented 1 month ago

@khotcholava e2e of checkbox are failing. Can you check them?

droshev commented 6 days ago

@khotcholava Can you follow up?