Defect hunting 10.04 for 0.16.0v

SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library

https://sap.github.io/fundamental-ngx

Apache License 2.0

267 stars 127 forks source link

Closed JKMarkowski closed 4 years ago

JKMarkowski commented 4 years ago

Issues from defect hunting on 10.04.

mikerodonnell89 commented 4 years ago

[ ] Tokenizer RTL mode - broken padding, need to figure out which side to align "more" text on, maybe provide option for the dev to decide? Also, keyboard support is backwards in RTL mode

Screen Shot 2020-04-10 at 8 39 35 AM

mikerodonnell89 commented 4 years ago

https://github.com/SAP/fundamental-ngx/issues/2313 First and last menu items have an extra bit of space before the top or bottom of the popover - to be address with the new menu styling - version 0.17.0

Screen Shot 2020-04-10 at 9 00 48 AM

mikerodonnell89 commented 4 years ago

Screen Shot 2020-04-10 at 9 05 07 AM

mikerodonnell89 commented 4 years ago

https://github.com/SAP/fundamental-ngx/issues/2314 Calendar - I think we should only display the week counter specifically on the week counter example. It is a strange feature that I think will usually do more to confuse than anything - documentation improvement -> open in a separate issue PR - https://github.com/SAP/fundamental-ngx/pull/2339 Screen Shot 2020-04-10 at 9 14 04 AM

JKMarkowski commented 4 years ago

[x] Calendar Keyboard support should consider RTL mode as well. - version 0.16.0

salarenko commented 4 years ago

[x] No arrows navigation and spacebar as select support in calendar | IE11 #2342
[x] Broken input addon in Select | IE11 #2340
[x] Dialog is not centered because of flexbox + position: absolute | IE11 #2324
[x] Dialog Body has rounded top corners hen header is visible | IE11 #2326
[x] Dialog cannot be dismissed by Esc key | IE11 #2324
[x] Input number spinner broken buttons | IE11 #2310
[x] Should these look like that? | Cross Browser https://github.com/SAP/fundamental-ngx/pull/2307
https://github.com/SAP/fundamental-ngx/issues/2315 Broken styles for menu examples, broken kyboard navigation | IE11 - fix in version 0.17.0 with the new markup
[x] Cannot check multi input because of padding | Cross Browser - https://github.com/SAP/fundamental-ngx/pull/2306
[x] Broken styles in Popover Placement example | Cross Browser - https://github.com/SAP/fundamental-ngx/pull/2305
[x] Broken Radio Buttons in Reactive example | Cross Browser #2311

mikerodonnell89 commented 4 years ago

https://github.com/SAP/fundamental-ngx/issues/2316 Table with checkboxes, select all doesn't work - open in a separate issue - Jedrzej PR

Screen Shot 2020-04-10 at 9 58 43 AM

JKMarkowski commented 4 years ago

IN PR Schematics are not prepared for new import of styling

"node_modules/fundamental-styles/dist/fonts.css",
"node_modules/fundamental-styles/dist/icon.css"

We can have some options to choose, or only default

@font-face {
    ...
}

We should also install

    "@sap-theming/theming-base-content": "^11.1.18"

automatically

mikerodonnell89 commented 4 years ago

[x] Shellbar - hover the search input or search input button - https://github.com/SAP/fundamental-ngx/pull/2308

Screen Shot 2020-04-10 at 10 02 24 AM

JKMarkowski commented 4 years ago

All Issues from there have been addressed