SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
263 stars 126 forks source link

Fixed card layout: Color of the KPI value is wrong #4243

Closed daisy-yovcheva closed 3 years ago

daisy-yovcheva commented 3 years ago

Describe the bug

If we want to present a positive state, the KPI values should be green; negative state - red; neutral - grey. But we don't use grey semantic color for KPI value and referring to a positive state. Fiori ref: https://ux.wdf.sap.corp/fiori-design-web/analytical-card/

droshev commented 3 years ago

@daisy-yovcheva can you give a link and screenshot to the component you are talking about?

daisy-yovcheva commented 3 years ago

Hi @droshev,

NGX issue screenshot:

Screen Shot 2020-12-10 at 9 36 31 PM

Here is a screenshot of a positive Analytical card [Number + k => should be green]:

Screen Shot 2020-12-10 at 9 33 49 PM

Visual core reference: https://wiki.wdf.sap.corp/wiki/display/visualcore/Card+%28Fiori+3%29+-+Analytical+Card

Thanks!

puru-hk commented 3 years ago

Verified changes are not reflecting in the fixed card layout. @DeepakSap14 can you update the fixed card examples

puru-hk commented 3 years ago

This issues is fixed is card. But in fixed card layout it is not fixed. See the attachment. Screenshot 2021-05-25 at 10.09.37.png

DeepakSap14 commented 3 years ago

@puru-hk , it has been merged few hours back, and currently netlify is not reflecting it. have to re-check when netlify is updated. you can check the PR build deployment here https://deploy-preview-5392--fundamental-ngx.netlify.app.

puru-hk commented 3 years ago

@DeepakSap14 I have check the above url still issue is not completely fixed as per the @daisy-yovcheva attachment.

DeepakSap14 commented 3 years ago

@puru-hk please verify this, if any issue you can reopen it.

puru-hk commented 3 years ago

@daisy-yovcheva I have tested in this url (https://deploy-preview-5509--fundamental-ngx.netlify.app/#/core/fixed-card-layout) it is working as expected. Please verify from your side and close this issue.