SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
256 stars 125 forks source link

feat: (Core|Platform) migrate to 0.16.1 styles #4773

Closed JKMarkowski closed 3 years ago

JKMarkowski commented 3 years ago

Please provide a link to the associated issue.

part of https://github.com/SAP/fundamental-ngx/issues/3684

Please provide a brief summary of this pull request.

Changes done in this PR are described in here

This is PR that applies changes due to migration to newest 0.16.1 version of styles. Shortly what's added:

Breaking Changes:

Please check whether the PR fulfills the following requirements

Documentation checklist:

netlify[bot] commented 3 years ago

Deploy preview for fundamental-ngx ready!

Built with commit 5c1f091b22b4c32f4e96e6cfdb40c77e188760d5

https://deploy-preview-4773--fundamental-ngx.netlify.app

mikerodonnell89 commented 3 years ago

Should the first column here have its top aligned with the second column? Not seeing a mention of this in the specs, but how it looks here feels awkward to me

Screen Shot 2021-02-26 at 1 30 13 PM
mikerodonnell89 commented 3 years ago

Breaking changes say

  • One Breaking Change - It's required to add fd-list-title inside fd-list-header.

but it's actually fd-list-group-header. And i think the addition of the growing input also would count as a breaking change

JKMarkowski commented 3 years ago

Should the first column here have its top aligned with the second column? Not seeing a mention of this in the specs, but how it looks here feels awkward to me

Screen Shot 2021-02-26 at 1 30 13 PM

@mikerodonnell89 Left column has been changed to be always on top - it's up to example, because on styles we have only left with more than 1 column. So for right it should be at the bottom and left always at top

JKMarkowski commented 3 years ago

@InnaAtanasova,@mikerodonnell89 Thanks for review - your comments have been addressed

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform A Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform A Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform A Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform A Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform A Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform A Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform A Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform A Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at

nikvalor commented 3 years ago

Project: null CORE Url: null This link will expire at

nikvalor commented 3 years ago

Project: null Platform B Url: null This link will expire at