Closed JKMarkowski closed 3 years ago
Deploy preview for fundamental-ngx ready!
Built with commit 5c1f091b22b4c32f4e96e6cfdb40c77e188760d5
Should the first column here have its top aligned with the second column? Not seeing a mention of this in the specs, but how it looks here feels awkward to me
Breaking changes say
- One Breaking Change - It's required to add
fd-list-title
insidefd-list-header
.
but it's actually fd-list-group-header
. And i think the addition of the growing
input also would count as a breaking change
Should the first column here have its top aligned with the second column? Not seeing a mention of this in the specs, but how it looks here feels awkward to me
@mikerodonnell89 Left column has been changed to be always on top - it's up to example, because on styles we have only left with more than 1 column. So for right it should be at the bottom and left always at top
@InnaAtanasova,@mikerodonnell89 Thanks for review - your comments have been addressed
Project: null CORE Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform A Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null Platform A Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null Platform A Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null Platform A Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null Platform A Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform A Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null Platform A Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform A Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Project: null CORE Url: null This link will expire at
Project: null Platform B Url: null This link will expire at
Please provide a link to the associated issue.
part of https://github.com/SAP/fundamental-ngx/issues/3684
Please provide a brief summary of this pull request.
Changes done in this PR are described in here
This is PR that applies changes due to migration to newest
0.16.1
version of styles. Shortly what's added:Breaking Changes:
fd-list-title
insidefd-list-group-header
.[growing]
input andfd-list-title-text
directivePlease check whether the PR fulfills the following requirements
Documentation checklist:
README.md