search

SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
268 stars 130 forks source link

DIV has an id attribute of 'fd-dynamic-page-header-id-6', which is not unique in the same DOM #9085

Closed nagbhushanr closed 1 year ago

nagbhushanr commented 1 year ago

Is this a bug, enhancement, or feature request?

Bug

Briefly describe your proposal.

This is regarding one of the accessibility bug. This DIV has an id attribute of 'fd-dynamic-page-header-id-6', which is not unique in the same DOM.

Which versions of Angular and Fundamental Library for Angular are affected? (If this is a feature request, use current version.)

angular - 13.3.7 fundamental ngx - 0.36.0

If this is a bug, please provide steps for reproducing it.

https://sap.github.io/fundamental-ngx/fundamental-ngx#/core/dynamic-page

Please provide relevant source code if applicable.

Store
More Information

Is there anything else we should know?

Expected behavior Documents that use markup languages must be well-formed. When documents are not well-formed user agents and/or assistive technology may not correctly parse and render the content to users. Many major user-agents are able to cope well with "bad" markup, however, to be consistent across all platforms and browsers well-formed markup must be used. This is especially important for assistive technology which may or may not be programmed to perform the same level of "coping" that can be found in browsers (which are created by multinational corporations) or assistive technology brands that cost several hundred dollars or more.

image

github-actions[bot] commented 1 year ago

Hello @nagbhushanr, thank you for using fundamental-ngx! The fundamental-ngx team will triage your issue as soon as possible.

N1XUS commented 1 year ago

Hello @nagbhushanr. Thank you for submitting this ticket. Unfortunately, I wasn't able to reproduce an issue you've described. Maybe you could provide code example for it?

nagbhushanr commented 1 year ago

image Here is the image of the above issue. if you look at the highlighted parts.... the id is similar for both. Inorder to observe this behavior:

  1. Go to fundamental ngx library web page - https://sap.github.io/fundamental-ngx/fundamental-ngx#/core/home
  2. Select version 0.36.2
  3. In search bar search for Dynamic Page
  4. Consider any example given in the page-> click to open in full screen
  5. inspect and observer fd-dynamic-page-subheader tag and you can see the above issue
N1XUS commented 1 year ago

@nagbhushanr thank you for the explanation. The issue has been already fixed with v0.37, so you can update to that version or higher

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.