Defect Hunting Sprint 115

InnaAtanasova commented 1 year ago

Please list the issues you've found during the defect hunting.

mikerodonnell89 commented 1 year ago

[x] Core carousel - need to replace placeholder images https://github.com/SAP/fundamental-ngx/pull/10061
[ ] Console error thrown in illustrated message doc page
[ ] input with inline help alignment looks off
[ ] reactive form input example - no visual indicator for what fields are required
[x] ~~list item with buttons - cutoff border on hover~~ will be fixed with styles update
[x] multi-combobox and multi-input mobile mode - removing tokens from the tokenizer is not reflected in the selection list when the popover is opened, nor the selected model - #10056
[x] multi-combobox group headers are focusable/clickable, guessing these shouldn't have interaction states - #10056
[ ] Multi-input - removing a token from the reactive form example throws ExpressionChangedAfterItHasBeenCheckedError
[x] Notification group in popover dialog - can't close dialog with close button - https://github.com/SAP/fundamental-ngx/pull/10063

[ ] Pagination, basic example - If you use the arrow keys to change pages, when you press enter, it appears as though the previous page is temporarily selected
[ ] Select mobile mode - if you open and close via keyboard, you can't open again. Probably not a real issue for mobile mode though
[ ] Select, adding and removing options example - if you add enough options that the popover gets a scrollbar, and use the arrow keys to navigate through to the new ones, the popover doesn't scroll with keyboard focus
[ ] Tree single selection mode - can select multiple options using a combination of keyboard + mouse
[ ] Global configuration examples not working

[ ] combobox - focus items in the list using keyboard arrow keys. Press escape. Focus does not return to combobox
[ ] list - need to press down arrow twice to go to next item after initial focus
[ ] smart filter bar - upon navigating to the docs page, immediately scrolls to an example at the bottom
[ ] table - sometimes, opening p13/sort/filter/etc dialog will open the dialog in fullscreen mode. Can't consistently recreate
[ ] table - initial state example - this popover looks bad
[ ] table - hiding columns example - missing padding on the text here
[ ] table - i think the sort glyph in the column headers is supposed to change directions with the sort direction https://github.com/SAP/fundamental-ngx/assets/2471874/ea283d67-76d0-4001-a2ed-53148c449c7b

mikerodonnell89 commented 1 year ago

Carousel loading indicator is off center

SAP / fundamental-ngx