SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
269 stars 130 forks source link

[Sourcing][Accessibility] fdp-select list box arrow button needs aria-label #9535

Closed I543348 closed 1 year ago

I543348 commented 1 year ago

Is this a bug, enhancement, or feature request?

Bug

Briefly describe your proposal.

The disabled user cannot understand what is the icon for on the screen, hence we need an aria-label for fdp-select. This is reported by Deutsche telekom customer

Which versions of Angular and Fundamental Library for Angular are affected? (If this is a feature request, use current version.)

angular 15 core / platform : 0.39.1-rc-5

If this is a bug, please provide steps for reproducing it.

This is replicable on https://sap.github.io/fundamental-ngx/#/core/select via jaws or voiceover , the arrow button needs an aria-label

Please provide relevant source code if applicable.

Is there anything else we should know?

fkolar commented 1 year ago

@I543348, When checking this reference implementation on SAPUI5 side , they have ariba-hidden=true for this specific usecase.

Do you mean this should be added to the arrow button?

I543348 commented 1 year ago

Yes @fkolar , we need aria-label for this use case for arrow button. Currently i am not able to check on NGX site for this directly , unable to move focus to fdp-select pressing tab key https://sap.github.io/fundamental-ngx/#/platform/select

fkolar commented 1 year ago

Closing, with keyboard and focus you never move on the arrow button and it makes less sense to have two UI element to expand the option this is why its one piece like here: https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_select

I543348 commented 1 year ago

After checking this issue in application , found that focus never goes to "arrow button" as its one-piece so screenreader reads out the whole select as list box.

I wasnt able to check this on current NGX site , this can be closed. Thanks @fkolar