SAP / fundamental-react

React implementation of the reusable component library designed in Fundamental Library Styles
https://sap.github.io/fundamental-react
Apache License 2.0
189 stars 77 forks source link

Implement DateTime picker #528

Open avalkowsky opened 5 years ago

avalkowsky commented 5 years ago

Hello,

I found out that the https://sap.github.io/fundamental-ngx/datetime-picker has implemented a datetime picker component. Some teams of our organisation are already using it in Angular projects.

In our project, react one, we use separate DatePicker (https://sap.github.io/fundamental-react/datepicker) and TimePicker (https://sap.github.io/fundamental-react/timepicker) from fundamental-react (with some adjustments due to https://github.com/SAP/fundamental-react/issues/498). It gives the user a different experience than the fundemental-ngx.

I'd like to use the same datetimepicker also in a React project and have a consistent fundamental look.

ngx version: Screenshot 2019-04-25 at 12 47 13

fundamental-react version: Screenshot 2019-04-25 at 12 46 43 Screenshot 2019-04-25 at 12 46 26

Do you plan to implement it and if so, how far is it on your road map?

Important sidenotes: 1) please bear in mind the problems with callbacks/data inputing and retrieval to/from the date picker & time picker components that already been spotted 2) the bear fundamental html&css library does not yet include a general date time picker component like the ngx version. Looks like it should be discussed as well 3) take a look also at date formats as they differ as well. Maybe you could make it configurable or at least the same in both :)?

Versions

fundamental-react: 0.5.1 fundamental-ngx: 0.4.4 fiori-fundamentals: 1.5.5


NOTE: Where applicable, please include uncropped screen captures.

DISCLAIMER: After triaging an issue, the fundamental-react team will see if it can be reproduced or confirmed. If more information is needed, the fundamental-react team will contact the author. Any issues awaiting responses from the author for more than 7 days will be closed. The author can re-open the issue at a later time if they can present the requested information.

PawelWojcik commented 5 years ago

Hi, Is there a chance that you'll add such component soon? Regards