SAP / fundamental-styles

SAP Design System component library for building SAP user interfaces with any web technology.
https://sap.github.io/fundamental-styles
Apache License 2.0
188 stars 60 forks source link

Segmented Button not showing state if disabled #2501

Closed trilodge closed 2 years ago

trilodge commented 3 years ago

Describe the bug A segmented button doesn't show its state if u either set it to disabled via attribute or set it to disabled via "is-disabled" class attribute.

Is this issue related to a specific component?

Segmented Button - https://sap.github.io/fundamental-styles/?path=/docs/components-button--primary#segmented-button

What version of the Fundamental Library Styles are you using?

0.18.0

What front-end framework are you implementing in, e.g., Angular, React, etc.?

Fundamental Styles + vue.js (w/o vue fundamentals because of outdated components)

To Reproduce Steps to reproduce the behavior:

  1. set disabled attribute to button within segmented button
  2. set "is-disabled" class attribute to button within segmented button
  3. button loses its selected state

Expected behavior The button still shows its selected or not selected state regardless of disabled or not.

Screenshots

Screenshot 2021-06-28 at 17 07 21

Desktop (please complete the following information):

Additional context The combination of "is-selected" and "is-disabled" or "disabled" is not represented in the CSS.

droshev commented 3 years ago

actually the problem is that we don't provide styling for selected disabled button:

<button class="fd-button fd-button--positive is-selected" disabled>Selected State</button>

this has to have the selected color/background

platon-rov commented 2 years ago

not reproducible, fixed