Before release Defect Hunting + Bug fixes

[InnaAtanasova]

• [ ] Test the components in all themes before the Horizon release.
• [ ] Distinguish the release blockers
• [ ] Bug fixes

Browsers for testing:

• [ ] Firefox - @g-cheishvili
• [ ] Edge - @platon-rov
• [ ] Chrome - @InnaAtanasova
• [ ] Safari - @N1XUS

Themes for testing:

• [ ] Quartz Light or Dark
• [ ] Horizon Morning
• [ ] Horizon Evening
• [ ] HCB for Horizon or HCW for Horizon

RTL and LTR testing too

Components for testing:

• [ ] Avatar
• [ ] Icons
• [ ] Busy Indicator
• [ ] Button Components - Badge on Button
• [ ] Button Components - Button
• [ ] Button Components - Button Shortcuts
• [ ] Button Components - Menu Button
• [ ] Button Components - Segmented Button
• [ ] Button Components - Toggle Button
• [ ] Calendar Components - Date Picker
• [ ] Checkbox
• [ ] Dialog and Popover Components - Dialog
• [ ] Dialog and Popover Components - Popover
• [ ] Dialog and Popover Components - Message Box
• [ ] Toolbar and Bar
• [ ] Input Components - Combobox
• [ ] Input Components - Input Field
  • [ ] Step Input
  • [ ] Input Group
• [ ] Input Components - Multi Input and Multi Combo
• [ ] Message Strip
• [ ] Page and Layout
  • [ ] Dynamic Page
  • [ ] Dynamic Side Content
  • [ ] Flexible Column Layout
  • [ ] Message Page
  • [ ] Page
• [ ] Radio Button
• [ ] Switch
• [ ] Tab Bar
• [ ] Text Components
• [ ] Cards and Tiles
• [ ] Shellbar
• [ ] Input Components - Dropdown
• [ ] List View
  • [ ] List
  • [ ] GridList
  • [ ] ObjectList
  • [ ] Table

[mikerodonnell89]

• [x] table - off-centered checkboxes on table columns with checkboxes (cozy mode) - https://github.com/SAP/fundamental-styles/pull/3399

• [x] table - bottom border of the first column in "fixed header" example appears as two lines https://github.com/SAP/fundamental-styles/pull/3405

[platon-rov]

• [x] - radio, checkbox missing borders in horizon themes, issue created on theming-base-content's side, https://github.com/SAP/theming-base-content/issues/10

• [x] - dynamic page, subtitle color is wrong https://github.com/SAP/fundamental-styles/pull/3397

Current:

Specs:

• [ ] Link, Horizon, text underline is absent in hc themes - https://github.com/SAP/fundamental-styles/pull/3409

  

• [x] Avatar Group, HC, border of the overflow button should be thickier https://github.com/SAP/fundamental-styles/pull/3398 Current

  

Specs:

• [x] Calendar, active state of year/month items is wrong https://github.com/SAP/fundamental-styles/pull/3392

  

• [x] Card missing its borders in HC themes. - https://github.com/SAP/fundamental-styles/pull/3400 Current:

  

  Specs:

  

• [x] Broken hover state for radio in Horizon HC themes. https://github.com/SAP/fundamental-styles/pull/3394

• [x] Broken hover state for checkbox in Horizon HC themes. https://github.com/SAP/fundamental-styles/pull/3394

• [x] Menu, Horizon, wrong border when in overflow mode https://github.com/SAP/fundamental-styles/pull/3432

  

• [x] Message box, States, HC themes, wrong border - https://github.com/SAP/fundamental-styles/pull/3401 Current:

  

  Specs:

  

• [x] Popover, HC, arrow border width is different from the popover body https://github.com/SAP/fundamental-styles/pull/3407

  

[droshev]

• [x] https://github.com/SAP/fundamental-styles/issues/3361

[droshev]

• [x] Avatar Group RTL any theme / any browser https://github.com/SAP/fundamental-styles/pull/3398
• [x] Avatar (Tile Icon Background)- HCB/HCW for Horizon - the icons are not visible https://github.com/SAP/fundamental-styles/pull/3398
• [x] Carousel Horizon (Item Loading error) - image is off https://github.com/SAP/fundamental-styles/pull/3380
• [x] Product Switch - Shellbar example is broken in RTL https://github.com/SAP/fundamental-styles/pull/3408
• [x] Table - Fixed Header - there are some borders missing in Horizon themes https://github.com/SAP/fundamental-styles/pull/3405

[N1XUS]

• [x] Calendar page: strange line https://github.com/SAP/fundamental-styles/pull/3392

  

• [x] Switch in Safari: Strange outline behaviour on focus #3395

[InnaAtanasova]

• [x] Avatar - Chrome | HCB Horizon | Tile Icon Background example https://github.com/SAP/fundamental-styles/pull/3398

The icon is not visible. (Morning Horizon)

(HCB Horizon)

[InnaAtanasova]

• [x] Avatar Group - Chrome | Quartz https://github.com/SAP/fundamental-styles/pull/3398 Focus is different on individual Avatar and the overflow Avatar

[InnaAtanasova]

• [x] Busy Indicator - Chrome - https://github.com/SAP/fundamental-styles/pull/3414 Wrong colors for Morning & Evening Horizon

Fundamental-styles:

Design specs:

[InnaAtanasova]

• [x] Radio Button Focus - @N1XUS #3423 Fund-styles:

Design specs:

[InnaAtanasova]

• [x] Menu https://github.com/SAP/fundamental-styles/pull/3411 Down state has a white focus and the specs don't.

Fund-styles:

Specs:

[InnaAtanasova]

• [x] Product Switch - Fiori Quartz https://github.com/SAP/fundamental-styles/pull/3402

The focus in active state should be white:

[InnaAtanasova]

• [x] ShellBar https://github.com/SAP/fundamental-styles/pull/3406 ShellBar actions (buttons) have dark focus. Should be white (contrast color)

[InnaAtanasova]

• [x] Switch On Switch toggling the focus outline "flickers". The correct behaviour can be seen at BTP implementation: https://fundamental-styles.netlify.app/?path=/docs/btp-experimental-design-toggles--checkbox&globals=theme:sap_horizon;fioriVersion:fioriNext

[InnaAtanasova]

• [x] User Menu search is broken https://github.com/SAP/fundamental-styles/pull/3403

[platon-rov]

• [x] Wizard - https://github.com/SAP/fundamental-styles/pull/3425

• Horizon, label text should be bold, optional text should have gray color Current:

  

  Specs:

  

• Horizon, current tab label in mobile mode shouldn't have blue color Current:

  

  Specs:

  

• Fiori, label should have grey color Current:

  

  Specs:

  

[platon-rov]

• [x] Tree, Fiori/Horizon, HC. Focus on the expanders look quite different from all other elements. Also state active is missing. However i didn't find how it should look like, probably we should ask designers about it.

Create a separate issue for future testing and integration with ngx

moved to https://github.com/SAP/fundamental-styles/issues/3495

[platon-rov]

• [x] Tokenizer should have border in HC themes. - #3404 Current:

  Specs:

  

WON'T FIX Note: Shouldn't have a border.

[platon-rov]

• [x] Tabs, HC, not enough contrast https://github.com/SAP/fundamental-styles/pull/3435

To be honest i didn't find specifications for this component, in the wiki i only found: Icon Tab Bar, Multi-Instance TabContainer, Wizard. In case Tabs component were renamed to Icon Tab Bar we should also deprecate Tabs.

Inna: IconTabBar should be used instead of Tabs. We kept Tabs because apps were using it, but it's no longer supported and you won't find specs for it.

[platon-rov]

• [x] Shellbar https://github.com/SAP/fundamental-styles/pull/3406

• Incorrect button border in active state. All the properties should be inherited from the transparent button, except overwritings. Transparent button should be used instead default button.

• Incorrect border button in HC themes.

[platon-rov]

• [x] Select - @InnaAtanasova https://github.com/SAP/fundamental-styles/pull/3418

• HC, no hover/active state on button (dropdown toggler)

  

• Incorrect active/dropdown-opened state of select button. Current:

  

  Specs:

  

[platon-rov]

• [x] Grid List, HC, filter bar, border should persist on hover/active - https://github.com/SAP/fundamental-styles/pull/3430

[g-cheishvili]

• [x] Counter colors does not seem right in HC themes and in Horizon, Mozilla https://github.com/SAP/fundamental-styles/pull/3413

[N1XUS]

• [x] Slider, wrong styling

[g-cheishvili]

• [x] - Grid List, Outline offset is too small https://github.com/SAP/fundamental-styles/pull/3421

Current:

Specs:

[g-cheishvili]

• [x] Micro process flow line is over icon #3404

[g-cheishvili]

• [x] Object status, Icon is not ideally centered and text needs more space horizontally

[g-cheishvili]

• [x] Mozilla, User menu search input is not vertically centered and top border is either not visible, either does not exist https://github.com/SAP/fundamental-styles/pull/3403

[platon-rov]

• [x] Micro Process Flow, some icons not visible in hc themes https://github.com/SAP/fundamental-styles/pull/3445

[N1XUS]

• [x] Horizontal navigation (Fiori). Wrong icon colors

@platon-rov: not yet implemented, https://github.com/SAP/fundamental-styles/issues/3247

[platon-rov]

• [x] Layout Grid, nested rows broken gap https://github.com/SAP/fundamental-styles/pull/3448

[mikerodonnell89]

• [x] Vertical navigation, incorrect focus outlines - https://github.com/SAP/fundamental-styles/pull/3451

[mikerodonnell89]

• [x] Horizontal nav focus

@platon-rov: not yet implemented, https://github.com/SAP/fundamental-styles/issues/3247

[g-cheishvili]

• [x] Readonly Textarea is focusable for some reason, with mouse click - https://github.com/SAP/fundamental-styles/pull/3465

[g-cheishvili]

• [ ] Tiles focus and hover states are not correct. Box shadow is missing in Horizon https://github.com/SAP/fundamental-styles/pull/3474

[g-cheishvili]

• [x] Menu selected item's focus, distance between outline and bottom border should be bigger - https://github.com/SAP/fundamental-styles/pull/3477

[g-cheishvili]

• [x] readonly step input is focusable with mouse - https://github.com/SAP/fundamental-styles/pull/3465

[g-cheishvili]

• [x] Input readonly state placeholder not visible - https://github.com/SAP/fundamental-styles/pull/3465

[platon-rov]

• [x] No text shadow on the link elements, but it's mentioned in specs. https://github.com/SAP/fundamental-styles/pull/3472