SAP / fundamental-styles

SAP Design System component library for building SAP user interfaces with any web technology.
https://sap.github.io/fundamental-styles
Apache License 2.0
183 stars 60 forks source link

fix(styles): add status color only to the status icon of Message Box #5477

Closed InnaAtanasova closed 2 weeks ago

InnaAtanasova commented 2 weeks ago

Related Issue

Closes none, related to an issue in FNGX

Description

Although not recommended, the user can add a dismiss button in the Message Box header. The dismiss button receives some CSS that is intended only for the status icon, like margin-right and color.

Screenshot 2024-07-04 at 2 59 02 PM

The solution for this issue is to target all icons that are not children of a button.

After the solution:

Screenshot 2024-07-04 at 3 04 50 PM

NOTE: the screenshots can't be found in the documentation as this is not something we would like users to do. I added the buttons in the header just to test the solution and removed them after.

netlify[bot] commented 2 weeks ago

Deploy Preview for fundamental-styles ready!

Name Link
Latest commit 3632faed5d17f0c1ef0a86a267cd0104df16d219
Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/6686f4ccc5b9b40008908a58
Deploy Preview https://deploy-preview-5477--fundamental-styles.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.