search

SAP / fundamental

Fundamental Library - SAP Design System Component Library
https://fundamental.netlify.app/
Apache License 2.0
269 stars 56 forks source link

Menu with icons - icon controls are not aligned with text when each item displays icon #1137

Closed mikerodonnell89 closed 5 years ago

mikerodonnell89 commented 5 years ago

Working on this enhancement: https://github.com/SAP/fundamental-ngx/issues/374 When each menu item has an icon, the icons are sized differently from the text, causing the icons to be misaligned to the corresponding text.

Is this issue related to a specific component?

Menu

What version of the Fiori Fundamentals are you using?

1.4.1

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

fundamental-ngx

What front-end framework are you implementing in, e.g., Angular, React, etc.?

Angular (however I could reproduce this issue with fiori-fundamentals)

To Reproduce Steps to reproduce the behavior: Add an icon to every menu item for a menu with icons

Screenshots

screen shot 2018-12-31 at 4 06 37 pm

Desktop (please complete the following information):

droshev commented 5 years ago

@saadmhybris we are able to release the shell-bar for angular, react, and vue so it is a blocker for all the libraries. Do you think you can fix is ASAP?