Docs: Update Type page based on GDD workshop

SAP / fundamental

Fundamental Library - SAP Design System Component Library

https://fundamental.netlify.app/

Apache License 2.0

269 stars 56 forks source link

Docs: Update Type page based on GDD workshop #184

Closed saad-mo closed 6 years ago

saad-mo commented 6 years ago

Type: https://sap.github.io/fundamental/fundamentals/type.html

Zeplin - https://app.zeplin.io/project/5a8c458b6e231fc65bddbdfb?seid=5ab9024281aa79813dcc0bd1

@LeoT7508

please create new visuals to support this page and let Saad know when they are ready.
Updated the website type page.

@saadmhybris

can we please make sure to add a download with the SAP 72 font on this page?

GDD workshop checklist - #170

LeoT7508 commented 6 years ago

@saadmhybris

This should be all done. Please close if you have everything you need.

saad-mo commented 6 years ago

@LeoT7508 we actually need some guidance here. the type has not been updated and still shows Roboto and Open Sans. Can you pls provide a design sheet of what we need to document on the website for the 72 font family? We don't have this information on zeplin.

@eboyer once Leo provides a design, you can work on this ticket.

LeoT7508 commented 6 years ago

@saadmhybris

This is all 72 type:

https://zpl.io/bLNoNvM

LeoT7508 commented 6 years ago

@saadmhybris

Website update: https://zpl.io/bWQylrn

eboyer commented 6 years ago

@LeoT7508 @saadmhybris ~ Hey! Should we be using the 72 font family across the board on the documentation site as well, opposed to Lato? Was that an update intended to be made with this feature? Let me know, I can roll it in with the rest of the PR.

saad-mo commented 6 years ago

I agree we should use the same font for the site. This way type won't beeld into components.

Closing this issue for now. We can open a new one for the doc site font.