SAP / fundamental

Fundamental Library - SAP Design System Component Library
https://fundamental.netlify.app/
Apache License 2.0
269 stars 56 forks source link

Review color accessibility #96

Closed xak closed 6 years ago

xak commented 6 years ago

It seems some of our colors are not passing AA WCAG. Please double check. https://sap.github.io/fundamental/colors.html

joseegm commented 6 years ago

@xak Have you more details? Manu could chime in. Some color combinations of the whole color pallete will not pass but those combinations should not be in use, as far as I know.

The text color/background color combination used should be mostly this ones.

screen shot 2018-02-27 at 10 14 05

@LeoT7508 Let's wait to get some more details on this from Manu,

LeoT7508 commented 6 years ago

@joseegm

I'll look into this when I get into the office.

xak commented 6 years ago

Neither action color passes. I did not test them all.

screen shot 2018-02-27 at 8 51 37 am

screen shot 2018-02-27 at 8 54 19 am

joseegm commented 6 years ago

At this point in the conversation last year i though we were all safe https://github.com/SAP/techne/issues/757#issuecomment-310975617

jeannewalters commented 6 years ago

I was just noticing on the cloud commerce invision screens, their colors are a bit darker blues and lighter grays. https://projects.invisionapp.com/share/Q3FEPPRD57V#/screens/274270862

saad-mo commented 6 years ago

The Teal on white we are using on the documentation site is also failing.

site-color-fail
LeoT7508 commented 6 years ago

@joseegm

This was all addressed in the email I sent out, I will close the issue.

joseegm commented 6 years ago

This is still not finished

LeoT7508 commented 6 years ago

@joseegm

This is finished.