search

SAP / generator-easy-ui5

Meta-generator various project types within the UI5 Universe
https://blogs.sap.com/2021/04/09/easy-ui5-3.0-from-community-contributions-to-community-plugins/
Apache License 2.0
243 stars 72 forks source link

Missing prompt for git repo initialization #109

Closed dfenerski closed 2 years ago

dfenerski commented 2 years ago

In a monorepo context, generating a git sub-repo is not needed and worse, confuses git which files to track even after the deletion of the .git directory. AFAIK there is no prompt or option to disable this, or am I missing something? Thanks in advance!

petermuessig commented 2 years ago

@dfenerski - do I get it right, you want to use a generator within you mono-repo and you want to avoid calling git init right? which subgenerator did you use?

dfenerski commented 2 years ago

@petermuessig yes, this is exactly my goal. I am using ts-app

petermuessig commented 2 years ago

Ok, I'll check - this should be fixed here: https://github.com/ui5-community/generator-ui5-ts-app/blob/main/generators/app/index.js#L172-L190

The end() step would also need a property to suppress the git initialization...

dfenerski commented 2 years ago

I can try to whip up a PR if that's acceptable? Would be like my first contribution ever :smiley:

petermuessig commented 2 years ago

That would be awesome @dfenerski - so I'll close this issue here...

matseee commented 2 years ago

It would be great if we could have this option in the generator-ui5-project generator as well. I will create a pull request with the same changes as in the pull request https://github.com/ui5-community/generator-ui5-ts-app/pull/16.