SAP / generator-easy-ui5

Meta-generator various project types within the UI5 Universe
https://blogs.sap.com/2021/04/09/easy-ui5-3.0-from-community-contributions-to-community-plugins/
Apache License 2.0
230 stars 72 forks source link

feat: add wdi5 as test framework #55

Closed vobu closed 3 years ago

vobu commented 3 years ago

this PR adds support for wdi5 as a test framework, via yo easy-ui5:wdi5,
targeted at ui5 stand-alone apps.

it holds a default config, a sample test file and compact documentation on how to use wdi5.
some convenience env vars are already respected at wdi5-test-time, as denoted in the README.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

vobu commented 3 years ago

ping @IObert - any chance this can get in this week? (bg: we're bootstrapping a great many apps via the generator these days and want to utilize wdi5 for each and every one)

IObert commented 3 years ago

Sorry for the delay, it is a busy week as you might expect :)

IObert commented 3 years ago

Thanks for your contribution! I just had a look at it (after merging - living on the edge :) ) and it runs great. It would be cool if you could change the inquirer prompts to "full questions" (starting with a capital letter, ending with a question mark etc.) and if you could add a small section in the main readme to explain who to sub-generator can be invoked.

But this is not so urgent. If can publish the version now as-is or wait for the next PR. It's up to you :)

IObert commented 3 years ago

And I just saw that eslint complains about a few missing semicolons in basic.test.js, login.page.js, page.js, secure.page.js, and example.e2e.js as well.

vobu commented 3 years ago

right on, will put the inquirer prompt in + add ; (sigh... 😄 )

vobu commented 3 years ago

And I just saw that eslint complains about a few missing semicolons in basic.test.js, login.page.js, page.js, secure.page.js, and example.e2e.js as well.

hm, you might wanna check your local eslint config and the workspace/project you're in 😆 - there is no login|secure.page.js or example.e2e.js or page.js in master. anyway, i

see #56

best, v.

IObert commented 3 years ago

Many thanks. I'll check where the eslint issue come from after TechEd :D