SAP / gigya-android-sdk

SAP CDC (Gigya) android sdk for mobile
Apache License 2.0
19 stars 13 forks source link

HttpNetworkProvider signs first request in queue twice #30

Closed AARazbakov closed 1 year ago

AARazbakov commented 2 years ago

In class HttpNetworkProvider in method release() first request is signed first time

_requestFactory.sign(queued.getRequest());

and the will be signed again in

queued.run();

Is that expected behavior? Other requests will be signed only once in run().

tal-mi commented 2 years ago

Probably not. I will check that and update. Signing the request twice is irrelevant and should not cause issues but if not needed I will alter the behavior.

Thanks, Tal

AARazbakov commented 2 years ago

Signing the request twice is irrelevant and should not cause issues but if not needed I will alter the behavior.

Yes, I don't see here any negative side effect, thanks.

tal-mi commented 1 year ago

The networking layer rewrite is comping up next Q. Closing this issue.