SAP / gigya-android-sdk

SAP CDC (Gigya) android sdk for mobile
Apache License 2.0
19 stars 13 forks source link

Add support for apps targeting Android S and above #43

Closed andresesfm closed 1 year ago

andresesfm commented 1 year ago

Android applications are now required to target Android S and higher.

In order to do that, applications have to keep these behavior changes into consideration: https://developer.android.com/about/versions/12/behavior-changes-12

Of particular concern for this library is the security change related to the immutability of PendingIntents described here: https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability

Not including a flag explicitly marking a request as mutable/immutable will cause an exception if the client app targets Android S or higher.

The following PR: https://github.com/SAP/gigya-android-sdk/pull/42 fixes this issue by conditionally adding the immutable flag depending on the Android version, hence maintaining backward compatibility.

tal-mi commented 1 year ago

Updated via versions: tfa-v2.1.0 auth-v2.2.0 Thanks for your contribution.