SAP / gigya-android-sdk

SAP CDC (Gigya) android sdk for mobile
Apache License 2.0
19 stars 13 forks source link

[Proposal] Improve Biometric error details with error code #59

Open navaronbracke opened 11 months ago

navaronbracke commented 11 months ago

In the Gigya Android Biometric SDK the error callbacks can be called multiple times.

For example when fingerprint identification fails, due to the user not pressing on the sensor correctly.

To distinguish the various error cases, the error callbacks have various specific values for the reason string that is passed to the callback.

However, these values are not available as constants to application developers. Also, having to match on string messages is error prone, because the error message might change in the future.

Context: https://github.com/SAP/gigya-flutter-plugin/pull/77#issuecomment-1746496180 and https://github.com/SAP/gigya-flutter-plugin/pull/77#issuecomment-1746683375

Proposal

Provide the error callbacks with an error code, besides the existing reason. This error code can be the error code from the Android Biometrics service itself, or an error code defined by the Gigya Android SDK for cases where there is no existing error code.

tal-mi commented 9 months ago

Hi, I will add this to the pipeline in our next Q. Hoping to get it prioritized.

MewanWA commented 1 month ago

@tal-mi Any update on the above? Hoping to get the gigya-flutter-plugin updated to complete the biometric implementation completely on Android.