Fix go-critic issues - Githubissues

SAP / go-hdb

SAP HANA Database Client for Go

Apache License 2.0

168 stars 57 forks source link

Fix go-critic issues #107

Closed mjtrangoni closed 1 year ago

mjtrangoni commented 1 year ago

Hi @stfnmllr,

This fix some trivial issues reported by go-critic.

The only one missing need to be checked more carefully. See,

golangci-lint run --disable-all --enable=gocritic ./...
driver/internal/protocol/fieldtype.go:385:2: singleCaseSwitch: should rewrite switch statement to if statement (gocritic)
        switch v := v.(type) {
        ^

cla-assistant[bot] commented 1 year ago

All committers have signed the CLA.

stfnmllr commented 1 year ago

Sorry, will not accept the pull request because we do not plan to be compliant to all Go linters available but stick to golint + go vet:

comment formatting: if this finds its way into golint I guess the source code editor Go add-ons would support it as well
replacing log.Fatal(...) by log.Print(...); return does not make any sense to me
and the switch (instead the if) is used because this is the standard read part iterator pattern in the entire code