search

SAP / go-hdb

SAP HANA Database Client for Go
Apache License 2.0
168 stars 57 forks source link

Consider going back to `go 1.21` in go.mod directive #138

Closed mx-psi closed 4 months ago

mx-psi commented 4 months ago

Hi! A few weeks ago, on v1.8.19, you switched to having bugfix version in your Go mod and I suggested setting that to go 1.21.0 in #135.

Since then, I have discussed elsewhere this cilium/ebpf/pull/1441 and found this change golang/go@27ed85d4d1702e868730ab6ea2ad6326988c615c that was released in Go 1.21.11 and Go 1.22.4 that I think probably fixed the issue that motivated this change (go 1.21 -> go 1.21.9) in the first place (this one golang/go/issues/62278).

Would you be willing to change the directive back to go 1.21? If not, what's the motivation? For context, I maintain a project that depends on go-hdb and want both to

  1. be able to depend on go 1.21 instead of go 1.21.0 (this has some smaller differences and in general seems more appropriate for a library)
  2. understand the motivation to change this on go-hdb to see if I should instead change it on my end.

Thanks!

stfnmllr commented 4 months ago

Hello, yes, as long as no 'tool' is going to complain, I am fine with 'go1.21' and did the change with https://github.com/SAP/go-hdb/releases/tag/v1.9.8. This is earliest going to change again (to 'go1.22') after the next go release ('go1.23') will be available.

mx-psi commented 4 months ago

Thank you!