search

SAP / gorfc

SAP NW RFC Connector for GO
Apache License 2.0
96 stars 42 forks source link

Revert "Merge pull request #14 from antihax/fix" #20

Closed databus23 closed 4 years ago

databus23 commented 4 years ago

The merged PR caused multiple compilation errors:

 go test -v ./gorfc
# github.com/SAP/gorfc/gorfc [github.com/SAP/gorfc/gorfc.test]
gorfc/gorfc.go:305:2: undefined: rc
gorfc/gorfc.go:305:37: undefined: length
gorfc/gorfc.go:305:75: undefined: utf8str
gorfc/gorfc.go:305:87: undefined: utf8Size
gorfc/gorfc.go:307:5: undefined: rc
FAIL    github.com/SAP/gorfc/gorfc [build failed]

Given that it also changes quite a lot without a proper test suite I propose to revert the committed changes and review the changes in more detail.