search

SAP / gorfc

SAP NW RFC Connector for GO
Apache License 2.0
96 stars 42 forks source link

minor fixes + go fmt #9

Closed SimonWaldherr closed 7 years ago

JonasDann commented 7 years ago

I would like to know why this solved the issue, described in the todo in line 280. The free operation caused errors for me, even though it should be necessary.

SimonWaldherr commented 7 years ago

I added some comments in the pull request (https://github.com/SAP/gorfc/pull/9/files) the defer C.free(unsafe.Pointer(utf8str)) change only works on Unix systems (i only tested it on Linux) and not on Windows. I could add platform dependent code to free the heap only on Linux.

SimonWaldherr commented 7 years ago

PS: i ran this code for several month on production systems