SAP / jenkins-library

Jenkins shared library for Continuous Delivery pipelines.
https://www.project-piper.io
Apache License 2.0
781 stars 594 forks source link

Add a step to undeploy an app from cloud foundry #2379

Closed rcosne closed 2 years ago

rcosne commented 4 years ago

Hi Piper,

There is a 'cloudFoundryDeploy' step to deploy an app from cloud foundry. It would be nice to have such a step to undeploy an app.

I need this to do temporary deployment in order to run my integration tests. Then, when the tests have been executed, I want to undeploy this application.

Best Regards, Rémy

radsoulbeard commented 4 years ago

Hi @rcosne ,

have you seen the steps cloudFoundryCreateSpace and cloudFoundryDeleteSpace ? In addition we also have cloudFoundryCreateService and cloudFoundryDeleteService if needed. We use that for our integration tests to create spaces on the fly, deploy the applications and delete them afterwards. That also prevents you from concurrent deployments in the integration stage when the pipeline is triggered multiple times.

Best regards, Thorsten

rcosne commented 4 years ago

Hi Thorsten,

Yes, I saw those steps. But we are using an hana cloud in our space, and many other service that can be reused. If I drop the full space, it will add a huge overhead to recreate them on the fly. So I just wanted to undeploy the MTA.

Regarding the concurrent deployments, I fix that issue by modifying the mta.yaml on the fly to make the services unique.

Best Regards, Rémy

radsoulbeard commented 4 years ago

Hi Rémy,

I cannot give any promise if or when somebody takes that request. As we are an open source project, we would be happy if you could contribute that step and open a PR for it.

Best regards, Thorsten

github-actions[bot] commented 2 years ago

Thank you for your contribution! This issue is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

github-actions[bot] commented 2 years ago

Issue got stale and no further activity happened. It has automatically been closed. Please re-open in case you still consider it relevant.