feat(sonar): wait for quality gate by default, so that pipeline fails when the quality gate fails

[anilkeshav27]

Changes

• [ ] Tests
• [ ] Documentation

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[anilkeshav27]

@stoyankanev , what are your thoughts, since this aligns with all other scanning tools, to fail the pipeline when the checks fail

[o-liver]

@anilkeshav27 As we are using this step in the Cloud CI service, we do not want it to be default true, as this can mean a long timeout before the pipeline continues. We encourage the users to set this via sonar-project.properties file. You can of course set it here in the Piper defaults and we would then switch it back to false for our service.

[stoyankanev]

@stoyankanev , what are your thoughts, since this aligns with all other scanning tools, to fail the pipeline when the checks fail Hm, the current QG conditions are not 100% aligned with the Functional Correctness standard requirements. Can we sync on this?

[github-actions[bot]]

Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

[github-actions[bot]]

Pull request got stale and no further activity happened. It has automatically been closed. Please re-open in case you still consider it relevant.