SAP / jenkins-library

Jenkins shared library for Continuous Delivery pipelines.
https://www.project-piper.io
Apache License 2.0
769 stars 582 forks source link

feat(helmExecute): automatically set appVersion #4935

Closed v0lkc closed 1 month ago

v0lkc commented 1 month ago

Changes

The appVersion attribute of a helmchart should normally be set to the version of the app which it ships. In our case it's most likely the version which piper generates with artifactPrepareVersion. If no other appVersion is specified in the pipeline configuration piper will automatically use the generated version once this is merged.

See https://helm.sh/docs/topics/charts/

appVersion: The version of the app that this contains (optional). Needn't be SemVer. Quotes recommended.
sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

v0lkc commented 1 month ago

/it-go

vstarostin commented 1 month ago

I think appVersion already can be updated by artifactPrepareVersion via additionalTargetTools

   artifactPrepareVersion:
      additionalTargetTools:
         - helm
  ...
volkc commented 1 month ago

I think appVersion already can be updated by artifactPrepareVersion via additionalTargetTools

   artifactPrepareVersion:
      additionalTargetTools:
         - helm
  ...

Thanks, I'll give it a try.