SAP / jenkins-library

Jenkins shared library for Continuous Delivery pipelines.
https://www.project-piper.io
Apache License 2.0
769 stars 582 forks source link

support for sub-module in maven build #4950

Closed vijayanjay closed 2 weeks ago

vijayanjay commented 1 month ago

Changes

Fixes below issues :

dimaste commented 1 month ago

what I am afraid here is that many projects specify paths as relative now... So this could break the step if the file couldn't be found. Have you tested this use cases? Thanks

vijayanjay commented 1 month ago

what I am afraid here is that many projects specify paths as relative now... So this could break the step if the file couldn't be found. Have you tested this use cases? Thanks

Verified in the places where the parent function is being called, its called in codeql, detect and mend. Looks like all are passing it with maven arguments. Our change is just appending the pwd with the relative path, so there shouldn't be any issues.

Googlom commented 3 weeks ago

/it-go

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Googlom commented 3 weeks ago

/it-go

vstarostin commented 2 weeks ago

/it-go

vstarostin commented 2 weeks ago

/it-go