SAP / kafka-connect-sap

Kafka Connect SAP is a set of connectors, using the Apache Kafka Connect framework for reliably connecting Kafka with SAP systems
Apache License 2.0
119 stars 54 forks source link

Added two previously undocumented config settings to the README #141

Closed pantaoran closed 1 year ago

pantaoran commented 1 year ago

I noticed that there are two settings in the BaseConfig.scala which are missing in the README. So I added the comments from the source code to the README.

They should probably be described better than I can, but this way at least they are not invisible anymore and people will know that these settings exist, even if they don't fully understand them yet.

Ideally someone with better understanding than me should further improve the descriptions.

cla-assistant[bot] commented 1 year ago

CLA assistant check
All committers have signed the CLA.

pantaoran commented 1 year ago

Pinging @elakito