search

SAP / less-openui5

Build OpenUI5 themes with Less.js.
Apache License 2.0
29 stars 13 forks source link

`font-face` declarations must not use CSS variables for the `src` attribute #267

Closed petermuessig closed 1 year ago

petermuessig commented 1 year ago

As reported by Hira Kshetry in the OpenUI5 Slack: https://openui5.slack.com/archives/C0A7MHSSJ/p1672783549112489, Icon Fonts don't work when using CSS variables.

I remember we discussed in the past, that the font-face declaration don't support variables in the src attribute. In this case, we might exclude the font-face declarations from the replacement with the CSS variables, when using less variables inside and furthermore manifest the concrete property value.

We should verify this part with the font-face and then adopt the plugin dependent on the result.

i556484 commented 1 year ago

Related internal incident: 2270189546

matz3 commented 1 year ago

Should be fixed via https://github.com/SAP/less-openui5/pull/257. Or is there something else not working?

matz3 commented 1 year ago

Closing as it's already solved via https://github.com/SAP/less-openui5/pull/257