search

SAP / luigi

Micro frontend framework
https://luigi-project.io
Apache License 2.0
821 stars 172 forks source link

Release script for classic luigi replaces nextrelease placeholder in container #3804

Closed JohannesDoberer closed 1 week ago

JohannesDoberer commented 1 week ago

When we run ./tools/release-cli/replaceInAllFiles.sh "NEXTRELEASE" "X.XX.X" like described in the ./scripts/tools/release-cli/release-cli.js script, the md files in container will also be touched. This should not be the case because container has its own release cycle.

ndricimrr commented 1 week ago

The script works fine. The label is mistaken in container. I made them different to differentiate them, but that was not a very good name pick it seems :D NEXTRELEASE - General release NEXT_RELEASE - Container release

Need to change 'NEXTRELEASE' string instances for container/ docs to 'NEXT_RELEASE'. But better than that might need to make the string NEXT_RELEASE_CONTAINER to avoid further confusion.

JohannesDoberer commented 1 week ago

Thx for clarification, my mistake! But yes, we should call it what you suggested to avoid this confusion again :)