[Privileges 2] "Mixed languages" in CLI

SAP / macOS-enterprise-privileges

For Mac users in enterprise environments, this application gives users control over the administration of their machine by elevating their level of access to administrator privileges on macOS. Users can set a timeframe in the application's settings to perform specific tasks, such as installing or removing an application.

Apache License 2.0

1.4k stars 149 forks source link

[Privileges 2] "Mixed languages" in CLI #117

Closed aduffner closed 1 month ago

aduffner commented 1 month ago

Tested on:

macOS 15.0.1 (24A348)
Privileges Beta 2.0.0 (1787)

The localization gets a little mixed up because the German word “Minuten” (minutes) is used after a sentence in the CLI that starts in English. Is the CLI intentionally multilingual?

In addition, it would be cool if the limit value would dynamically adapt to newer settings and only apply if it is lower than the current limit value (if it comes from a pushed, renewed profile or a new user setting).

mthielemann commented 1 month ago

@aduffner Thanks for reporting this. The language issue has been fixed in build 1791.

As for the automatic adjustment of the remaining time for admin rights, I'm not sure. From a user's perspective, it's a really bad experience when I request admin rights for a certain amount of time and then the time is suddenly reduced for no apparent reason. Technically that wouldn't be a problem, but what would be the practical benefit?

aduffner commented 1 month ago

@mthielemann You are right, this would irritate the user and only makes sense in edge cases. An example would be that the user has selected “never” as the expiration date and this should be set to 4 hours, as never is no longer permitted due to a new configuration. Of course it would apply at login/ restart (if set up), but not immediately.

mthielemann commented 1 month ago

@aduffner In this edge case you could deploy a profile first that forces standard user privileges (using the EnforcePrivileges key) and after this, remove the EnforcePrivileges key and deploy the new expiration interval.