search

SAP / node-hdb

SAP HANA Database Client for Node
Apache License 2.0
317 stars 98 forks source link

typescript definitions #180

Open larshp opened 3 years ago

larshp commented 3 years ago

Hi, Are you interested in a PR that builds typescript definitions for this project?

The automatic generation of types from Javascript was introduced in https://devblogs.microsoft.com/typescript/announcing-typescript-3-7/#declaration-and-allowjs

Automatic generation is not perfect, but its a quick win, much better than nothing

A PR could look much like https://github.com/micromatch/picomatch/pull/53

larshp commented 2 years ago

any thoughts?

jeffalbion commented 2 years ago

We welcome any PRs from the community that would help improve the driver: TypeScript support is certainly a welcome addition.

Our development team is mainly focused on enhancements for existing SAP applications using this driver moving to HANA Cloud so it is not likely we will get to this enhancement soon, but it is on our backlog.