SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js
Apache License 2.0
251 stars 73 forks source link

Segmentation Fault if wrong parameters are passed to RFC #100

Closed PaulWieland closed 4 years ago

PaulWieland commented 5 years ago

I just found that if you call an RFC and pass an invalid data type in the structure, you can cause nodeJS to seg fault.

To reproduce it, call RFC_READ_TABLE and pass this stucture:

    {
        QUERY_TABLE: "MARA",
        OPTIONS: "A string instead of an array"
    }

The RFC expects options to be an array, and it throws an error, but then crashes.

image
bsrdjan commented 5 years ago

Thanks for catching this one. The fix will be shipped with next release.

bsrdjan commented 4 years ago

Fixed in rc11