SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js
Apache License 2.0
251 stars 73 forks source link

win32 cross compilation issue #130

Closed jmarcgit closed 4 years ago

jmarcgit commented 4 years ago

Hi,

I had to install cmake-js 6.x in order to compile a win32 version on a win64 host. Then all ll I had to do was to set the -A option before running npm install : npm config set cmake_js_A "Win32"

Problem is that cmake-js version 5.x doesn't support the CMAKE -A option. I'm using VS 16 2019 and the -A option is now mandatory in order to build x86 binaries.

Could you please upgrade cmake-js to version 6 ?

bsrdjan commented 4 years ago

Thank you for the hint about so elegant solution. Will test on Windows and add to documentation.

cmake-js is already upgraded in master, comes out with next npm release.

jmarcgit commented 4 years ago

You are welcome, thank you. Took me a while to understand why the parameter was ignored during the build. I will try to compile the master branch.

jmarcgit commented 4 years ago

I confirm it works perfectly fine with master branch.