search

SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js
Apache License 2.0
251 stars 73 forks source link

V2 pre win build fix (1909 and 2004) #154

Closed nmalenovic closed 4 years ago

nmalenovic commented 4 years ago

Unfortunately v2.0 assumes tar groks --force-local - Windows' tar doesn't. build reports:

Downloading node-v14.5.0-headers.tar.gz to C:/Users/********/AppData/Roaming/npm/node_modules/node-rfc/build/node-v14.5.0-headers.tar.gz ...
tar: Option --force-local is not supported
...
CMake Error at CMakeLists.txt:74 (file):
  file RENAME failed to rename
...

Removed --force-local and tested builds on Windows OS 1909 and 2004. Works like a champ for both local and global install. See Issue #152 for test script and results.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.