SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js
Apache License 2.0
251 stars 73 forks source link

Request Compatibility with official NodeJS Docker Image #176

Closed PaulWieland closed 3 years ago

PaulWieland commented 3 years ago

I referred to this in issue 165, but decided it should be it's own thread.

Right now it is not possible to use npm install node-rfc under NodeJS's official docker images because the version of libstdc++6 that comes with those images is slightly too old. There is no easy way to upgrade it either because the package the library comes in is already at the latest available revision.

That leaves us with having to build a base image with all the compiler tools, compile node-rfc, then copy the package to a slim container (and then get npm to play nice with it). If anyone knows a cleaner/faster way, please let me know.

I would imagine that these docker images are the starting place for many node developers, so I don't think I'm alone here.

Details:

bsrdjan commented 3 years ago

Thanks @PaulWieland, the lower GLIBC version makes sense. The next releases will be compatible with glibc >= 2.17 and libstdc++ >= 6.0.20 (GLIBCXX_3.4.20, which are available on distributions natively supporting GCC 4.9, such as Ubuntu 14.04 and Debian 8.

The build toolchain is now exactly the same one used for official NodeJS builds, based on Centos and devtoolset-8:

nodejs/node/BUILDING.md#supported-toolchains

The Centos docker image used for node-rfc builds is now maintained within SAP fundamental-tools project, please feel free to test:

fundamental-tools/docker

PaulWieland commented 3 years ago

I just wanted to say that this update has been a huge help. My docker images are now 40% of the size they used to be, and they build that much faster.