search

SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js
Apache License 2.0
251 stars 73 forks source link

npm reports EBADENGINE on supported platform #194

Closed nikmalenovic closed 3 years ago

nikmalenovic commented 3 years ago

I ran into a weird situation while installing on a fresh installation of Windows (Version 10.0.19041.685 x64) using node (v15.5.0 x64) with npm (7.3.0) and RFC SDK (PL 7 for SAP NetWeaver RFC SDK 7.50 for Windows x64 64bit):

C:\...>npm -g i node-rfc
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'node-rfc@2.3.1',
npm WARN EBADENGINE   required: { node: '~10 >=10.20 || >=12.17', npm: '^6.11.3' },
npm WARN EBADENGINE   current: { node: 'v15.5.0', npm: '7.3.0' }
npm WARN EBADENGINE }

removed 1084 packages, changed 3 packages, and audited 4 packages in 2m

found 0 vulnerabilities

Subsequent link into my project produced this:

C:\...>npm link node-rfc
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'node-rfc@2.3.1',
npm WARN EBADENGINE   required: { node: '~10 >=10.20 || >=12.17', npm: '^6.11.3' },
npm WARN EBADENGINE   current: { node: 'v15.5.0', npm: '7.3.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'node-rfc@2.3.1',
npm WARN EBADENGINE   required: { node: '~10 >=10.20 || >=12.17', npm: '^6.11.3' },
npm WARN EBADENGINE   current: { node: 'v15.5.0', npm: '7.3.0' }
npm WARN EBADENGINE }

despite this, it seems functional with rudimentary tests.

so, more of an annoyance then an actual problem?

bsrdjan commented 3 years ago

It is functionally fine but annoying nevertheless. The package.json engine restrictions will be relaxed in next release, supporting npm 7.

emretuna commented 3 years ago

any fix for this?

bsrdjan commented 3 years ago

It is already fixed in main branch.

bsrdjan commented 3 years ago

Fixed with just released 2.4.0

bsrdjan commented 3 years ago

@ForestReaper please try just released 2.4.3. In case it does not work, create new issue, describe steps to reproduce and attach the error log.

maximinogomez commented 3 years ago

@bsrdjan same issue as above. Still not fixed for me. Screen Shot 2021-05-27 at 3 36 46 PM

bsrdjan commented 3 years ago

@maximinogomez

please try just released 2.4.3. In case it does not work, create new issue, describe steps to reproduce and attach the error log. The screenshots are about angular, perhaps you need to raise issue there.