SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js
Apache License 2.0
249 stars 73 forks source link

Error in typescript on sapnwrfc-client.d.ts on RfcConnectionParameters #243

Closed uxkjaer closed 2 years ago

uxkjaer commented 2 years ago

Describe the bug By using your example from the readme and trying to use it in typescript, then it won't compile as you need to add all other parameters in the RfcConnectionParameters.

To Reproduce Create a .ts file and add the following code


import noderfc = require("node-rfc");

const pool = new noderfc.Pool({ connectionParameters: {dest: "MME"} });

(async () => {
    try {
        // get a client connection instance
        const client = await pool.acquire();
        if (client){
        // invoke ABAP function module, passing structure and table parameters

        // ABAP structure
        const abap_structure = {
            RFCINT4: 345,
            RFCFLOAT: 1.23456789,
            RFCCHAR4: "ABCD",
            RFCDATE: "20180625", // ABAP date format
            // or RFCDATE: new Date('2018-06-25'), // as JavaScript Date object, with clientOption "date"
        };
        // ABAP table
        let abap_table = [abap_structure];

        const result = await client.call("STFC_STRUCTURE", {
            IMPORTSTRUCT: abap_structure,
            RFCTABLE: abap_table,
        });

        // check the result
        console.log(result);
    }
    } catch (err) {
        // connection and invocation errors
        console.error(err);
    }
})();`