search

SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js
Apache License 2.0
249 stars 73 forks source link

Update sapnwrfc-client.d.ts #244

Closed uxkjaer closed 2 years ago

uxkjaer commented 2 years ago

not all parameters for connection is needed. By adding partial, we won't get errors in typescript.

Fix #243

bsrdjan commented 2 years ago

Thank you @uxkjaer. Would you mind to move the fix here, so that type definitions will be automatically generated in future releases as well: https://github.com/SAP/node-rfc/blob/main/src/ts/wrapper/sapnwrfc-client.ts#L170

uxkjaer commented 2 years ago

Thank you @uxkjaer. Would you mind to move the fix here, so that type definitions will be automatically generated in future releases as well: https://github.com/SAP/node-rfc/blob/main/src/ts/wrapper/sapnwrfc-client.ts#L170

Hi @bsrdjan I've reverted the original fix and pushed it into the proposed spot. Thanks

phhoef commented 2 years ago

Hi @bsrdjan,

I've downloaded node-rfc version 2.5.1 and running in the exact same problem. Typescript is complaining, that the other 125 properties are missing when only defining DEST. I looked in the sapnwrfc-client.ts file and noticed, that it is not defined partial. Am I using a wrong version?

bsrdjan commented 2 years ago

It is a bug, will be fixed in next release.