search

SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js
Apache License 2.0
249 stars 73 forks source link

Fixed memory leak for RFCTYPE_XSTRING #246

Closed samuel-c-allan closed 2 years ago

samuel-c-allan commented 2 years ago

Allocated byteValue in nwrfcsdk.cc:618 is not freed automatically (a fact that only becomes apparent if you transfer very large XSTRING types) resulting in a memory leak that is significant for applications that deal with large amounts of XSTRING data (my app would, for instance, would crash after a few minutes due to lack of memory - others will likely not experience it on this kind of scale, but the memory leak is nevertheless a concern in my opinion).

The fix is very simple and uses the finalizer feature of node-addon-api. Looking forward to your comments

bsrdjan commented 2 years ago

why is this closed, is it some undesired side-effect found during testing?