search

SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js
Apache License 2.0
249 stars 73 forks source link

Package fails to install under NodeJS 16.17 #266

Closed benjamin-sieffert closed 1 year ago

benjamin-sieffert commented 1 year ago

Describe the bug Installation of this package just fails in the prebuild-install step under node 16.17.

To Reproduce Compare installation under 16.16 to 16.17. Should be pretty easy to reproduce, since it fails both locally for me (Arch Linux) and on the official GH Ubuntu runner (ubuntu-latest). Note that there seems to be an abundance of sub-procs created and a lot of scripts named like /tmp/dependencies-####.sh are created.

Screenshots From GH pipeline: ii-rfc

From local installation attempt: ii-tmp

Additional context This could as well be a NodeJS bug, but probably you have a better shot than me in digging into what exactly is failing when trying to install under 16.17, and then filing a bug with NodeJS if applicable.

Best regards

bsrdjan commented 1 year ago

The node-rfc installation works fine with node 16.17.0 on ubuntu latest docker container.

Why do you think the issue is related to node-rfc? Can you share the full installation log?

benjamin-sieffert commented 1 year ago

OK it turns out that version 2.7 of node-rfc already contains the fix for this, sorry for the bother. :) (We were still on 2.6.1.)