SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js
Apache License 2.0
252 stars 73 forks source link

sapnwrfc.node binary shipped in `lib\binding` folder #290

Closed bsrdjan closed 1 year ago

bsrdjan commented 1 year ago

sapnwrfc.node built for the last platform in release build chain, is shipped in lib/binding folder. When preinstall/install scripts fail or when build from source fails, the shipped binary can make the impression that everything is OK because the package looks complete. On Linux platform it may unnoticed and on other platform the node-rfc fails to load because sapnwrfc.node is host-platform incompatible. The solution is to exclude sapnwrfc.node from package because there is no one fit-for-all default.

The issue is discovered during deno installation investigation: https://github.com/denoland/deno/issues/17411