Add v59 win32 to the release?

SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js

Apache License 2.0

252 stars 73 forks source link

Add v59 win32 to the release? #51

Closed drummerv closed 6 years ago

drummerv commented 6 years ago

node-pre-gyp ERR! Tried to download(404): https://github.com/sap/node-rfc/releases/download/0.1.14/rfc-v0.1.14-node-v59-win32-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for node-rfc@0.1.14 and node@9.10.1 (node-v59 ABI, unknown) (falling back to source compile with node-gyp)

Using v9.10.1

It tried compiling it from source but failed, is that normal for unsupported versions?

EDIT: Oops, should have read the description. Anyway, the fallback to build doesn't work with it.

bsrdjan commented 6 years ago

v59 binary added in new 0.1.15 release, please feel free to test.

Built form source fallback might fail on Windows when node-pre-gyp locally installed, due to known node-pre-gyp issue. If still fails (on Windows?), uninstall locally and install globally, just like in release.sh.

bsrdjan commented 6 years ago

If any issues please reopen.