search

SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js
Apache License 2.0
252 stars 73 forks source link

Async/Await version? #65

Closed zig999 closed 5 years ago

zig999 commented 5 years ago

Hi there! In the examples page, https://github.com/SAP/node-rfc/blob/napi/examples/README.md, shows one where it's possible to use async/await methods like open and call. Which version is that?

bsrdjan commented 5 years ago

@next version (npm install node-rfc@next)

zig999 commented 5 years ago

Thanks @bsrdjan . Just a fast sugestion, ou guys shouls add a note at README.md for windows users, something like: "Add env variable SAPNWRFC_HOME pointing to your SAP NW RFC SDK root folder." It breaks when trying to build.

bsrdjan commented 5 years ago

Thanks for the suggestion. SAPNWRFC_HOME is actually required on all platforms and I would add the link in README, to already existing documentation

bsrdjan commented 5 years ago

Added to README and documentation.