added Fallback Solution for Electron and VSCode

SAP / node-rfc

Asynchronous, non-blocking SAP NW RFC SDK bindings for Node.js

Apache License 2.0

252 stars 74 forks source link

added Fallback Solution for Electron and VSCode #95

Closed Mabenan closed 4 years ago

Mabenan commented 5 years ago

Solve for Issue https://github.com/SAP/node-rfc/issues/94

CLAassistant commented 5 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Richter Daniel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

bsrdjan commented 4 years ago

Thank you very much @Mabenan for the PR. After replacing GYP with CMAKE the fix not needed any more.