Code Correctness: Erroneous String Compare

SAP / olingo-jpa-processor-v4

The JPA Processor fills the gap between Olingo V4 and the database, by providing a mapping between JPA metadata and OData metadata, generating queries and supporting the entity manipulations.

Apache License 2.0

127 stars 79 forks source link

Code Correctness: Erroneous String Compare #93

Closed QiAnXinCodeSafe closed 4 years ago

QiAnXinCodeSafe commented 4 years ago

https://github.com/SAP/olingo-jpa-processor-v4/blob/bc0c49d89cb49367554c89ed26a46cbe748e7243/jpa/odata-jpa-processor/src/main/java/com/sap/olingo/jpa/processor/core/converter/JPAStructuredResultConverter.java#L60 Strings should be compared with the equals() method, not == or !=.

wog48 commented 4 years ago

Thanks for supporting,

this will be corrected with the next release.