SAP / open-ux-odata

Enable community collaboration to jointly promote and facilitate best in class framework and tooling capabilities when working with OData services.
Apache License 2.0
51 stars 10 forks source link

FEATURE - handle changeset scenarios for 412 warnings #829

Closed otsquest101 closed 2 months ago

otsquest101 commented 2 months ago
changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 3d9822734617b97e1e6083acfd3755b01a8dbc33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------------------ | ----- | | @sap-ux/fe-mockserver-core | Patch | | @sap-ux/ui5-middleware-fe-mockserver | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

otsquest101 commented 2 months ago

Can you please describe in the pull request the different scenarios that should be supported and how they are supposed to work ?

The whole concept of grouping the 412 response is pretty unclear to me and the code might need further tweaking based on the details.

  • Multiple request in changeset or isolated mode
  • Some part failing with 412, other ok, other failing with 500.

Hi @nlunets I have resolved the comments, added description for the 412 scenarios addressed with this PR. There is one scenario of multiple errors (multiple 412s and 500.) for which I am following up with models and backend colleagues. If you agree, this can be added as a follow up PR to this one.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud